Port TNEF plugin to new rendering plugin API
ClosedPublic

Authored by vkrause on Oct 7 2017, 10:17 AM.

Details

Summary

By using the standard inline attachment container we also get the proper
attachment links now.

Diff Detail

Repository
R81 KDE PIM Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Oct 7 2017, 10:17 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 7 2017, 10:17 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss added inline comments.Oct 9 2017, 8:43 AM
plugins/messageviewer/bodypartformatter/autotests/data/tnef-one-file.mbox.html
16

we need the dir setting to support right-to-left languages

vkrause added inline comments.Oct 9 2017, 7:19 PM
plugins/messageviewer/bodypartformatter/autotests/data/tnef-one-file.mbox.html
16

this is broken in the generic attachment container already then, no?

knauss added inline comments.Oct 10 2017, 8:46 AM
plugins/messageviewer/bodypartformatter/autotests/data/tnef-one-file.mbox.html
16

looks like this. But I never tested right-to-left language, so i don't know.

knauss accepted this revision.Oct 10 2017, 10:18 PM

needs testing with r-t-l language, but anyways that it not part of this patch

This revision is now accepted and ready to land.Oct 10 2017, 10:18 PM
This revision was automatically updated to reflect the committed changes.