Extend MessagePart API as needed for the TNEF plugin
ClosedPublic
Actions

Authored by vkrause on Oct 7 2017, 10:14 AM.

Details

Reviewers

Commits

R94:b02241748845: Extend MessagePart API as needed for the TNEF plugin

Summary

Mainly NodeHelper and temporary file access. This enabled a bit of cleanup
in the built-in rendering code too, towards getting rid of the friendship
overuse.

Diff Detail

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Oct 7 2017, 10:14 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 7 2017, 10:14 AM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

knauss added inline comments.Oct 9 2017, 8:38 AM

mimetreeparser/src/viewer/messagepart.cpp
427	return nodeHelper()->writeNodeToTempFile(content());

address review comment

knauss accepted this revision.Oct 13 2017, 4:41 PM

This revision is now accepted and ready to land.Oct 13 2017, 4:41 PM

Closed by commit R94:b02241748845: Extend MessagePart API as needed for the TNEF plugin (authored by vkrause). · Explain WhyOct 14 2017, 10:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			messageviewer/src/messagepartthemes/default/defaultrenderer.cpp (4 lines)
M			messageviewer/src/messagepartthemes/default/plugins/attachmentmessagepartrenderer.cpp (6 lines)
M			mimetreeparser/src/bodyformatter/textplain.cpp (5 lines)
M			mimetreeparser/src/viewer/bodypartformatter.cpp (6 lines)
M			mimetreeparser/src/viewer/messagepart.h (10 lines)
M			mimetreeparser/src/viewer/messagepart.cpp (25 lines)
M			mimetreeparser/src/viewer/nodehelper.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20424	5709f80		Oct 7 2017, 10:14 AM	★	★
Diff 2	20685	0a8c66a	address review comment	Oct 13 2017, 4:24 PM	★	★
Diff 3	20723	ece5d7d	R94:b02241748845bfd4353f96509c06a3da64881e5a	Oct 14 2017, 10:09 AM	★	★