kcm_input: Refactor the code and add support for libinput under X11
AbandonedPublic
Actions

Authored by xuetianweng on Oct 7 2017, 8:56 AM.

Details

Reviewers

davidedmundson
mart

Summary

FEATURE: 383379

Move the UI setup from mouse.cpp to kcmmouse.ui.
Refactor the code like kcm_touchpad to enable support for different backend. We only have X11 for now.
Add support for libinput based acceleration settings and reverse scrolling.
Do not apply reverse scrolling to touchpad, which will cause conflict with kcm touchpad.
Use libinput provided Macro instead of raw string in both touchpad and mouse kcm.

Test Plan

Manually tested on weston (just test for no crashing) and X11.

Diff Detail

Repository

R119 Plasma Desktop

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

xuetianweng created this revision.Oct 7 2017, 8:56 AM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 7 2017, 8:56 AM

using a UI file and add libinput support.

xuetianweng retitled this revision from kcm_input: Refactor the code to enable support of multiple backends. to kcm_input: Refactor the code and add support for libinput under X11.Oct 7 2017, 1:14 PM

xuetianweng edited the summary of this revision. (Show Details)

xuetianweng edited the test plan for this revision. (Show Details)

ngraham added a subscriber: ngraham.Oct 7 2017, 2:18 PM

ping

valeriymalov mentioned this in D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup.Oct 24 2017, 11:07 AM

This is going to be a necessity for Wayland, given that libinput is mandatory.

davidedmundson added inline comments.Oct 24 2017, 1:10 PM

cmake/modules/FindXorgLibinput.cmake
8 ↗	(On Diff #20440)	that's not your name...
kcms/CMakeLists.txt
58 ↗	(On Diff #20440)	do you mean "AND" especially given this is optional?

Wow, very nice! I'm still not sure if on Wayland we should combine Touchpad and Mouse KCMs to one "Pointers" KCM how it was proposed years ago, because their properties in libinput are very similar. But since you already did the work for adding multiple backend to the Mouse KCM let's go with two separate ones now!

Your change is very big though. Could we split it up in a patch series? Basically by your bullets point in the description. Then we would have the following patches in order:

UI in kcmmouse.ui.
Backend refactoring
Libinput mouse acceleration and revert scroll (on X)
Libinput macros
No revert scrolling for touchpads

Maybe (2) needs to switch position with (3) and/or (4) with (5).

xuetianweng mentioned this in D8456: Port kcm input to UI File..Oct 24 2017, 10:32 PM

xuetianweng mentioned this in R119:987b4dec9264: Port kcm input to UI File..Oct 25 2017, 2:46 AM

xuetianweng mentioned this in D8460: Refactor kcm_input to enable having multiple backends..Oct 25 2017, 4:16 AM

ngraham edited the summary of this revision. (Show Details)Oct 25 2017, 5:00 PM

Being split into small patches

xuetianweng mentioned this in R119:40f8edd70f4a: Refactor kcm_input to enable having multiple backends..Nov 9 2017, 3:09 AM

Have you had any time to produce some more of the individual patches for this? It would be really great to get a libinput-compatible version of the input KCM for 5.12.

ngraham mentioned this in T7964: Wayland Mouse KCM.Feb 19 2018, 1:25 AM

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptFeb 19 2018, 1:25 AM

Revision Contents
Changeset List

		Path
M		kcms/input/CMakeLists.txt (46 lines)
A	M	kcms/input/backends/x11.cmake (25 lines)
A	M	kcms/input/backends/x11/x11mousebackend.h (56 lines)
A	M	kcms/input/backends/x11/x11mousebackend.cpp (267 lines)
M		kcms/input/kapplymousetheme.cpp (65 lines)
A	M	kcms/input/logging.h (26 lines)
A	M	kcms/input/logging.cpp (22 lines)
M		kcms/input/main.cpp (77 lines)
M		kcms/input/mouse.h (38 lines)
M		kcms/input/mouse.cpp (288 lines)
A	M	kcms/input/mousebackend.h (59 lines)
A	M	kcms/input/mousebackend.cpp (44 lines)
A	M	kcms/input/mousesettings.h (48 lines)
A	M	kcms/input/mousesettings.cpp (65 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20421	543411a		Oct 7 2017, 8:56 AM	★	★
Diff 2	20440	543411a	using a UI file and add libinput support.	Oct 7 2017, 1:13 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
665c6bc2fcc7	313bb1db13c1	543411ae882a	Weng Xuetian	kcm_input: Refactor the code to enable support of multiple backends. (Show More…)	Oct 7 2017, 8:53 AM