be less aggressive when to disable borders
ClosedPublic

Authored by mart on Oct 6 2017, 2:15 PM.

Details

Summary

if the control height is
2*Metrics::LineEdit_FrameWidth + option->fontMetrics.height()
it means that "it just fits", therefore still draw the frame

the qqc2-desktop style uses that logic to get default line edit
heights, so they all got disabled by just one pixel

Test Plan

tested qwidget and qml apps

Diff Detail

Repository
R113 Oxygen Theme
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Oct 6 2017, 2:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 6 2017, 2:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart retitled this revision from ibe less aggressive when to disable borders to be less aggressive when to disable borders.EditedOct 6 2017, 2:16 PM
mart added reviewers: Plasma, hpereiradacosta.

all the line edit frames were flat white rectangles before

hpereiradacosta accepted this revision.Oct 6 2017, 2:20 PM

Shit it, thanks !
In fact I remember making the same fix some time back in breeze. Must have forgotten to backport it to oxygen.

This revision is now accepted and ready to land.Oct 6 2017, 2:20 PM
This revision was automatically updated to reflect the committed changes.