Fix location of Open action on the toolbar.
ClosedPublic

Authored by elvisangelaccio on Oct 4 2017, 2:38 PM.

Details

Summary

The file_open standard action should always appear after file_new. This
is not the case in the Kate toolbar, where we have Open before New.

This happens because there is a custom file_open group that breaks the
kxmlgui merging index (the file_open action gets 0 rather than 1).

This was introduced a long time ago with:

https://websvn.kde.org/?view=revision&revision=350820

The log message just says

"to allow the template plugin a button in a relevant position"

which is probably no longer relevant. Dropping this group makes Open
appear in the toolbar after New, as expected.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio created this revision.Oct 4 2017, 2:38 PM
Restricted Application added a project: Kate. · View Herald TranscriptOct 4 2017, 2:38 PM

Does the file template plugin still exist? If so, did you test this?

Does the file template plugin still exist? If so, did you test this?

It seems it doesn't, the doc for it was removed with 777cdae21c.

lueck added a subscriber: lueck.EditedOct 6 2017, 2:22 AM

Does the file template plugin still exist? If so, did you test this?

The file template plugin was removed in 2015 by Christoph Cullmann with https://cgit.kde.org/kate.git/commit/?id=fbb7bb4285bccba39d2d5a6a35085143938f10c5

dhaumann accepted this revision.Oct 6 2017, 5:50 AM

OK, in that case please commit. Thanks!

This revision is now accepted and ready to land.Oct 6 2017, 5:50 AM
This revision was automatically updated to reflect the committed changes.