This entry is defined as required (cmp. IPlugin API docs) with values either
"Global" or "Project". Having it not set and thus being treated with a value
of empty string results e.g. in plugins not being loaded or unloaded after
the user enabled or disabled plugins in the settings.
Details
Details
- Reviewers
brauch - Group Reviewers
KDevelop - Commits
- R32:864d6dcf1836: Add missing X-KDevelop-Category entries to plugins' metadata
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I grepped around and I a) can see why not setting this key breaks things and b) don't see why it would be wrong. I think it's just an oversight that it wasn't. Thank you!
Comment Actions
Great work, I wonder if we could get some basic plugin json validator integrated into our buildsystem... would be useful for such situations, I guess!
Comment Actions
Yes, having a data validation build step would be good in general, agreed very much. In old times people used the validation checks in krazy for this, but these days krazy/EBN seems to be out of people's view, and then krazy also misses out any data generated/modified at build time.
IMHO ECM would/could provide a generic approach to this, so common data schemes could be covered out of the box and checks for custom ones could be added easily.
Right now we only have appstream data validation hacked into KDECMakeSettings.cmake. Which is such a lazy hack that it makes me cry everytime I see it ;)
CI could then take over some task from EBN.