Expose MessagePart directly to the attachment Grantlee templates
ClosedPublic

Authored by vkrause on Oct 3 2017, 11:40 AM.

Details

Summary

This reduces code duplication and makes this easier to re-use for plugins.
Additionally, it fixes two issues with attachment rendering:

  • for many attachments we weren't showing links, making it unnecessarily hard to save or open them
  • we were double-escaping attachment labels and descriptions

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Oct 3 2017, 11:40 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 3 2017, 11:40 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss added inline comments.Oct 3 2017, 1:22 PM
mimetreeparser/autotests/data/details/openpgp-encrypted-partially-signed-attachments.mbox.html
56

why no links here?

mimetreeparser/autotests/data/details/openpgp-signed-encrypted-two-attachments.mbox.html
54

why we don't get links here?

vkrause added inline comments.Oct 3 2017, 1:24 PM
mimetreeparser/autotests/data/details/openpgp-encrypted-partially-signed-attachments.mbox.html
56

that's the body, not the header

mimetreeparser/autotests/data/details/openpgp-signed-encrypted-two-attachments.mbox.html
54

same here

knauss accepted this revision.Oct 3 2017, 1:26 PM
This revision is now accepted and ready to land.Oct 3 2017, 1:26 PM
This revision was automatically updated to reflect the committed changes.