Differential D8119

Add "Folders" to Dolphin's search type panel
AbandonedPublic
Actions

Authored by ngraham on Oct 2 2017, 9:44 PM.

Details

Reviewers
None
Group Reviewers
Dolphin
KDE Applications
Summary

BUG: 269334

Adds a "Folder" radio button to Dolphin's Find panel, simultaneously adding a new feature and also filling an awkward space (now all three columns have the same height)

Test Plan

Tested in KDE Neon. The feature works, and when "Folders" is selected, searches are limited to folders.

Before:

After:

Diff Detail

Repository
R318 Dolphin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Oct 2 2017, 9:44 PM
Restricted Application added a subscriber: Dolphin. · View Herald TranscriptOct 2 2017, 9:44 PM
ngraham edited the test plan for this revision. (Show Details)Oct 2 2017, 9:45 PM
ngraham added reviewers: Dolphin, KDE Applications.
ngraham added a comment.Oct 3 2017, 2:53 PM

Well as long as one of them gets in, I'm happy! :) I slightly prefer my patch since I think the more natural place for Folders is closer to the beginning than the end, but I won't block anything on that.

elvisangelaccio added a comment.Oct 3 2017, 9:14 PM
In D8119#151982, @ngraham wrote:

Well as long as one of them gets in, I'm happy! :) I slightly prefer my patch since I think the more natural place for Folders is closer to the beginning than the end, but I won't block anything on that.

Feel free to change that with another patch :)

Revision Contents
Changeset List

Diff 20273

View Options

src/search/dolphinfacetswidget.h

Loading...
View Options

src/search/dolphinfacetswidget.cpp

Loading...