Remove DefaultRendererPrivate from the render plugin interface
ClosedPublic

Authored by vkrause on Oct 2 2017, 11:08 AM.

Details

Summary

Instead, add a RenderContext class for this purpose. This will likely grow
over time as we move more of the internal rendering and external plugins
to this API, but for now it gets the job done of isolating us from private
implementation details.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Oct 2 2017, 11:08 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 2 2017, 11:08 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss accepted this revision.Oct 2 2017, 2:10 PM
This revision is now accepted and ready to land.Oct 2 2017, 2:10 PM
knauss requested changes to this revision.Oct 2 2017, 2:42 PM

TextMessagePartRenderer removal of alignText() is missing here.

This revision now requires changes to proceed.Oct 2 2017, 2:42 PM
vkrause added inline comments.Oct 2 2017, 2:51 PM
messageviewer/src/messagepartthemes/default/plugins/textmessagepartrenderer.cpp
44

^ this?

knauss accepted this revision.Oct 2 2017, 3:01 PM
knauss added inline comments.
messageviewer/src/messagepartthemes/default/plugins/textmessagepartrenderer.cpp
44

yepp :)

argh to much diffs :)

This revision is now accepted and ready to land.Oct 2 2017, 3:01 PM
This revision was automatically updated to reflect the committed changes.