Differential D8100

Workaround crash on lockscreen close
ClosedPublic
Actions

Authored by davidedmundson on Oct 2 2017, 10:10 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R133:b85d1a63fccb: Workaround crash on lockscreen close
Summary

See QTBUG-55460 for details. It's causing our unit test crash when
closing the lock screen with SIGTERM.

It's not worth fixing "properly" as it goes away with QtQuickControls2

Test Plan

gdb showed it was this crash, which I'd seen before

Ran locker --test
sent SIGTERM
locker closed, but didn't crash

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Oct 2 2017, 10:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 2 2017, 10:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.Oct 3 2017, 5:13 PM
graesslin added a subscriber: graesslin.
graesslin added inline comments.
greeter/greeterapp.cpp
127

nitpick: whitespaces.

This revision is now accepted and ready to land.Oct 3 2017, 5:13 PM
Closed by commit R133:b85d1a63fccb: Workaround crash on lockscreen close (authored by davidedmundson). · Explain WhyOct 3 2017, 5:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mgreeter/greeterapp.cpp (7 lines)

Diff 20312

View Options

greeter/greeterapp.cpp

Loading...