Cleanup HtmlWriter API
ClosedPublic

Authored by vkrause on Oct 1 2017, 9:16 AM.

Details

Summary
  • merge Interface::HtmlWriter and HtmlWriter
  • remove queue() and flush(), which with the single synchronous buffer send to WebEngine have no meanings anymore
  • remove the unused CSS argument to begin()
  • remove TeeHtmlWriter, its debugging use has been superseded by the much more convenient direct access to the HTML source code in the mail source view

This prepares the next step of making HtmlWriter conceptually a QIODevice,
so we can use it directly with Grantlee's streaming API.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Oct 1 2017, 9:16 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 1 2017, 9:16 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss accepted this revision.Oct 1 2017, 12:25 PM

does this have also changes inside kdepim-addons?

This revision is now accepted and ready to land.Oct 1 2017, 12:25 PM

Sure, same kind of changes you see in the using code here.

knauss added a comment.Oct 1 2017, 2:17 PM

Sure, same kind of changes you see in the using code here.

than please bump mimetreeparser version.

This revision was automatically updated to reflect the committed changes.