Merge Interface::MessagePart and MessagePart
ClosedPublic
Actions

Authored by vkrause on Sep 30 2017, 10:37 AM.

Details

Reviewers

Commits

R94:1e5bea9795a1: Merge Interface::MessagePart and MessagePart

Summary

Interface::MessagePart is neither pure-virtual nor is it ever instantiated
now that legacy handling has been separated out, which removes its reason
to exist. This allows simplifying its usage, as we no longer need to
deal with the distinction.

Diff Detail

Repository

R94 PIM: Message Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Sep 30 2017, 10:37 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 30 2017, 10:37 AM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

knauss added inline comments.Sep 30 2017, 12:09 PM

messageviewer/src/messagepartthemes/default/plugins/messagepartrenderer.cpp
37–38	useless now, because it is always a MimeTreeParser::MessagePart:)
mimetreeparser/src/viewer/messagepart.h
77	doesn't it need to be virtual?
150	please keep them, these are for the new planned interface

knauss mentioned this in D8066: Give legacy BPF::format() handling its own MessagePart sub-class.Sep 30 2017, 12:10 PM

knauss added inline comments.Sep 30 2017, 1:07 PM

mimetreeparser/src/viewer/messagepart.h
150	okay lets kill them for the moment

vkrause marked an inline comment as done.Sep 30 2017, 1:14 PM

vkrause added inline comments.

mimetreeparser/src/viewer/messagepart.h
77	virtual is inherited from QObject here. Technically this should be override, but override on dtors makes some compilers choke.

addressed review comments

knauss accepted this revision.Sep 30 2017, 1:18 PM

This revision is now accepted and ready to land.Sep 30 2017, 1:18 PM

Closed by commit R94:1e5bea9795a1: Merge Interface::MessagePart and MessagePart (authored by vkrause). · Explain WhySep 30 2017, 1:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			messageviewer/src/messagepartthemes/default/autotests/rendertest.cpp (9 lines)
M			messageviewer/src/messagepartthemes/default/defaultrenderer.h (4 lines)
M			messageviewer/src/messagepartthemes/default/defaultrenderer.cpp (28 lines)
M			messageviewer/src/messagepartthemes/default/defaultrenderer_p.h (8 lines)
M			messageviewer/src/messagepartthemes/default/messagepartrendererbase.h (4 lines)
M			messageviewer/src/messagepartthemes/default/plugins/attachmentmessagepartrenderer.h (2 lines)
M			messageviewer/src/messagepartthemes/default/plugins/attachmentmessagepartrenderer.cpp (2 lines)
M			messageviewer/src/messagepartthemes/default/plugins/messagepartrenderer.h (2 lines)
M			messageviewer/src/messagepartthemes/default/plugins/messagepartrenderer.cpp (11 lines)
M			messageviewer/src/messagepartthemes/default/plugins/textmessagepartrenderer.h (2 lines)
M			messageviewer/src/messagepartthemes/default/plugins/textmessagepartrenderer.cpp (2 lines)
M			messageviewer/src/viewer/objecttreeemptysource.h (2 lines)
M			messageviewer/src/viewer/objecttreeemptysource.cpp (2 lines)
M			messageviewer/src/viewer/objecttreeviewersource.h (2 lines)
M			messageviewer/src/viewer/objecttreeviewersource.cpp (2 lines)
M			mimetreeparser/autotests/setupenv.h (3 lines)
M			mimetreeparser/src/bodyformatter/applicationpgpencrypted.h (2 lines)
M			mimetreeparser/src/bodyformatter/applicationpgpencrypted.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/applicationpkcs7mime.h (2 lines)
M			mimetreeparser/src/bodyformatter/applicationpkcs7mime.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/mailman.h (2 lines)
M			mimetreeparser/src/bodyformatter/mailman.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/multipartalternative.h (2 lines)
M			mimetreeparser/src/bodyformatter/multipartalternative.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/multipartencrypted.h (2 lines)
M			mimetreeparser/src/bodyformatter/multipartencrypted.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/multipartmixed.h (2 lines)
M			mimetreeparser/src/bodyformatter/multipartmixed.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/multipartsigned.h (2 lines)
M			mimetreeparser/src/bodyformatter/multipartsigned.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/texthtml.h (2 lines)
M			mimetreeparser/src/bodyformatter/texthtml.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/textplain.h (2 lines)
M			mimetreeparser/src/bodyformatter/textplain.cpp (2 lines)
M			mimetreeparser/src/bodyformatter/utils.cpp (4 lines)
M			mimetreeparser/src/interfaces/bodypartformatter.h (27 lines)
M			mimetreeparser/src/interfaces/bodypartformatter.cpp (50 lines)
M			mimetreeparser/src/interfaces/objecttreesource.h (2 lines)
M			mimetreeparser/src/viewer/bodypartformatter.cpp (8 lines)
M			mimetreeparser/src/viewer/messagepart.h (41 lines)
M			mimetreeparser/src/viewer/messagepart.cpp (255 lines)
M			mimetreeparser/src/viewer/objecttreeparser.h (6 lines)
M			mimetreeparser/src/viewer/objecttreeparser.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	20135	a225e99		Sep 30 2017, 10:37 AM	★	★
Diff 2	20152	a225e99	addressed review comments	Sep 30 2017, 1:15 PM	★	★
Diff 3	20157	d5e5142	R94:1e5bea9795a1c99827e66881c427a102f7b97899	Sep 30 2017, 1:48 PM	★	★