Differential D806

Re-add Url editor and add KPropertyGenericSelectionEditor
ClosedPublic
Actions

Authored by staniek on Jan 13 2016, 2:08 PM.

Tags

Subscribers

Kexi-Devel-list

Details

Reviewers

Commits

R13:cab4a018ba5f: Re-add Url editor and add KPropertyGenericSelectionEditor

Summary

+ update the example app

Test Plan

Try the kpropertyexample: Url, Existing File, Overwrite File, Dir properties.

Diff Detail

Repository

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

staniek updated this revision to Diff 1931.Jan 13 2016, 2:08 PM

staniek retitled this revision from to Re-add Url editor and add KPropertyGenericSelectionEditor.

staniek updated this object.

staniek edited the test plan for this revision. (Show Details)

staniek added a reviewer: piggz.

staniek added a subscriber: Kexi-Devel-list.

staniek added a project: KProperty.Jan 13 2016, 2:09 PM

piggz added inline comments.Jan 13 2016, 8:51 PM

src/editors/KPropertyUrlEditor.cpp
75	Using a property editor to select a file and getting a Save dialog/button seems odd. Surprised me to get a save dialog.

staniek added inline comments.Jan 16 2016, 7:31 PM

src/editors/KPropertyUrlEditor.cpp
75	Both Open and Save is a valid use case. There may be a property set that lets the user to pick filename(s) to save.

piggz accepted this revision.Jan 16 2016, 7:37 PM

piggz edited edge metadata.

This revision is now accepted and ready to land.Jan 16 2016, 7:37 PM

staniek closed this revision.Jan 16 2016, 7:44 PM

Revision Contents
Changeset List

			Path	Packages
M			examples/window.cpp (18 lines)
M			src/CMakeLists.txt (2 lines)
M			src/KDefaultPropertyFactory.cpp (2 lines)
M			src/KPropertyEditorView.h (13 lines)
M			src/editors/CMakeLists.txt (5 lines)
V			src/editors/{KPropertyGenericSelectionEditor.h ← urledit.h} (41 lines)
A	M		src/editors/KPropertyGenericSelectionEditor.cpp (72 lines)
A	M		src/editors/KPropertyUrlEditor.h (71 lines)
A	M		src/editors/KPropertyUrlEditor.cpp (110 lines)
V			src/editors/{urledit.h → KPropertyGenericSelectionEditor.h}
D	M		src/editors/urledit.cpp (91 lines)

Diff 1931

examples/window.cpp

Loading...

src/CMakeLists.txt

Loading...

src/KDefaultPropertyFactory.cpp

Loading...

src/KPropertyEditorView.h

Loading...

src/editors/CMakeLists.txt

Loading...

src/editors/KPropertyGenericSelectionEditor.h

Loading...

src/editors/KPropertyGenericSelectionEditor.cpp

Loading...

src/editors/KPropertyUrlEditor.h

Loading...

src/editors/KPropertyUrlEditor.cpp

Loading...

src/editors/urledit.h

Loading...

src/editors/urledit.cpp

Loading...