Add ECM dependency to libalkimia blueprint
AbandonedPublic

Authored by vonreth on Sep 29 2017, 3:31 AM.

Details

Summary

libalkimia fails to build if extra cmake modules are not present. Therefore added ECM as a dependency in the libalkimia blueprint.

Diff Detail

Repository
R138 Craft
Lint
Lint Skipped
Unit
Unit Tests Skipped
mhubner created this revision.Sep 29 2017, 3:31 AM

Hi Marc,

Thanks for your contribution.
The path looks right but can you please change
self.runtimeDependencies["frameworks/extra-cmake-modules"] = "default"
to
self.buildtimeDependencies["frameworks/extra-cmake-modules"] = "default"

With this change you can directly push your change :)

Thanks!

Hannah

vonreth requested changes to this revision.Sep 29 2017, 6:23 AM
This revision now requires changes to proceed.Sep 29 2017, 6:23 AM
mhubner updated this revision to Diff 20124.Sep 30 2017, 12:35 AM

Hi Hannah,

Thanks for the hint, I updated the diff accordingly (think it should be buildDependencies, not buildtimeDependencies based on other blueprints I reviewed). I don't have write access to the repository though. Would you be able to push the change on my behalf?

Thanks!
Marc

vonreth commandeered this revision.Oct 20 2017, 12:02 PM
vonreth edited reviewers, added: mhubner; removed: vonreth.
vonreth abandoned this revision.Oct 20 2017, 12:03 PM