Qt already does double buffering so it is not needed.
Details
Details
- Reviewers
rempt - Group Reviewers
Krita - Commits
- R37:a79989abfa29: Remove redundant buffering in QPainter canvas
R37:ecd6ca4a4f14: Remove redundant buffering in QPainter canvas
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Hm, I'm not sure how safe this is.. I think this was introduced in this commit:
commit fc8a3acfbd845a80993ac8af346069dda582ee7c
Author: Lukáš Tvrdý <lukast.dev@gmail.com>
Date: Thu Sep 10 22:18:12 2009 +0000
Use QImage as buffer for QPainter based canvas. Not the whole image is painted, just changed rect. Now tools can use composite modes to paint their overlays. This is possible fix for tool overlay and will be tested. If you encounter performence problems, let me know. This can be turned off safely by commenting line 24 in header file. svn path=/trunk/koffice/; revision=1022148
And I wonder whether this rationale is still relevant?
Comment Actions
I would say no, the painting code from below repaints the whole thing from bottom up no matter what, so the buffer isn't doing anything extra for tool overlays.
Comment Actions
Yeah... some of the removed lines were changed in D7973 and I made this patch on top of that...