Differential D8012

Only assert on broken GL when we're rendering using GL
ClosedPublic
Actions

Authored by davidedmundson on Sep 27 2017, 2:31 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R120:3eb76ed6c126: Only assert on broken GL when we're rendering using GL
Test Plan

set backend. Didn't get an error message

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 27 2017, 2:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 27 2017, 2:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Sep 27 2017, 2:38 PM
This revision is now accepted and ready to land.Sep 27 2017, 2:38 PM
Closed by commit R120:3eb76ed6c126: Only assert on broken GL when we're rendering using GL (authored by davidedmundson). · Explain WhySep 27 2017, 2:50 PM
This revision was automatically updated to reflect the committed changes.
graesslin added a subscriber: graesslin.Sep 27 2017, 3:15 PM
graesslin added inline comments.
shell/desktopview.cpp
60

Is it correct to compare to software? What if vulkan get's introduced?

davidedmundson added inline comments.Sep 27 2017, 3:20 PM
shell/desktopview.cpp
60

Then we change it..

The reason it's done this way round is currently is that setSceneGraph("aaerkwlakrjaldkfj") will result in it being GL.

They seem to be migrating to using enums, which will make life better in the future.

Revision Contents
Changeset List

PathPackages
Mshell/desktopview.cpp (20 lines)

Diff 19989

View Options

shell/desktopview.cpp

Loading...