Differential D8011

[ScreenEdgeEffect] Create glow Svg on demand
ClosedPublic
Actions

Authored by broulik on Sep 27 2017, 2:28 PM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:a7c396caeb29: [ScreenEdgeEffect] Create glow Svg on demand
Summary

Keeps it from loading the Svg and all the Plasma stuff (Theme etc) that comes with it on startup.

Test Plan

Found this while investigating a crash in KWindowSystem (used by Plasma Theme).
Reduces RAM consumption after kwin start by ~1 MiB, didn't measure time
Edge glow for screen edge and panel still works

I chose to un-const cornerGlowSize rather than doing a const_cast. I noticed that the glow size differs between OpenGL and XRender but this is without this patch also.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 27 2017, 2:28 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 27 2017, 2:28 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin accepted this revision.Sep 27 2017, 4:25 PM
This revision is now accepted and ready to land.Sep 27 2017, 4:25 PM
Closed by commit R108:a7c396caeb29: [ScreenEdgeEffect] Create glow Svg on demand (authored by broulik). · Explain WhySep 28 2017, 8:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 20018

View Options

effects/screenedge/screenedgeeffect.h

Loading...
View Options

effects/screenedge/screenedgeeffect.cpp

Loading...