Differential D7998

Stop setting the QQC1 style in startkde
ClosedPublic
Actions

Authored by arojas on Sep 26 2017, 6:49 PM.

Details

Reviewers
davidedmundson
fvogt
Commits
R120:335116210b7c: Stop setting the QQC1 style in startkde
Summary

The reason why this was added (D7257) is not valid anymore now that we set the QQC2 style in C++. Setting it causes crashes in QGuiApplications that need to be worked around with an ugly hack in plasma-integration.

Test Plan

Launch a QQC1 application, there's no warning that the "org.kde.desktop" style can not be found.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas created this revision.Sep 26 2017, 6:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 26 2017, 6:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
arojas added a comment.Oct 3 2017, 10:24 AM

Ping. Would be nice to get this in 5.11 to reduce environment noise.

davidedmundson accepted this revision.Oct 3 2017, 10:39 AM
This revision is now accepted and ready to land.Oct 3 2017, 10:39 AM
Closed by commit R120:335116210b7c: Stop setting the QQC1 style in startkde (authored by arojas). · Explain WhyOct 3 2017, 6:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mstartkde/startkde.cmake (10 lines)
Mstartkde/startplasma.cmake (10 lines)

Diff 19950

View Options

startkde/startkde.cmake

Loading...
View Options

startkde/startplasma.cmake

Loading...