Differential D7997

[tabbox] Create X11Filter on establishKeyboardGrab
ClosedPublic
Actions

Authored by graesslin on Sep 26 2017, 6:43 PM.

Details

Reviewers
broulik
Group Reviewers
KWin
Plasma
Commits
R108:bc88f8477725: [tabbox] Create X11Filter on establishKeyboardGrab
Summary

Creating the X11Filter directly on startup caused a regression as the
filter got too early in the chain and stole events from the
XInputIntegrationFilter. We don't need the filter all the time, but only
when we have established the TabBox grab. Likewise we can destroy the
filter again when releasing the TabBox grab. So it's much more
encapsulated now.

BUG: 385032

Test Plan

Only compile tested, I'm on Wayland

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Sep 26 2017, 6:43 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 26 2017, 6:43 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
broulik accepted this revision.Sep 26 2017, 7:02 PM
broulik added a subscriber: broulik.

On X verified that Meta now opens Kickoff again and that Alt+Tab and Alt+Backtab and Mousewheel and selecting windows whilst in tabbox still work.

This revision is now accepted and ready to land.Sep 26 2017, 7:02 PM
graesslin added a comment.Sep 26 2017, 7:08 PM

Thanks for testing!

Closed by commit R108:bc88f8477725: [tabbox] Create X11Filter on establishKeyboardGrab (authored by graesslin). · Explain WhySep 26 2017, 7:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtabbox/tabbox.cpp (6 lines)

Diff 19953

View Options

tabbox/tabbox.cpp

Loading...