update elisa docbook
ClosedPublic

Authored by lueck on Sep 26 2017, 5:14 AM.

Details

Summary

use CCBYSA4, this the new docbook license
remove appendix installation with entities &install.intro.documentation; + &install.compile.documentation; which will be removed in later kdoctools
move two paras from appendix installation to using chapter

Test Plan

checkXML5 index.docbook

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck created this revision.Sep 26 2017, 5:14 AM
ltoscano requested changes to this revision.Sep 26 2017, 7:45 AM
ltoscano added a subscriber: ltoscano.

It requires a bump of Frameworks to 5.38 (and the authorization of the authors, but only Matthieu contributed to it, so it's easier).

This revision now requires changes to proceed.Sep 26 2017, 7:45 AM

I agree with the license change if it is more in line with the KDE policy.

It seems to me that the part about no configuration needed before running the application has been removed. The whole paragraph looks to me useful information. What do you think ?

lueck updated this revision to Diff 19969.Sep 27 2017, 8:56 AM

readd para abount configuration
bump kf5 to 5.38, required for CCBYSA4 license as pointed out by Luigi

mgallien accepted this revision.Sep 27 2017, 9:18 AM
lueck updated this revision to Diff 20530.Oct 9 2017, 6:38 PM

update diff to reflect the recent docbook commits

Thinking more about it, we don't necessarily need the newer Frameworks version to use CC BY-SA 4.0. We need it only if we want to use the official entity with the generated links, but nothing prevents the usage of a local entity until the requirements are bumped.
This is a general solution. If for specific projects the bump of the Frameworks requirement is fine or required for other reasons, then it's another story.

In any case, the date in the <date> tag should be updated.

I am fine fine with a bump since a fix in 5.39 is needed to prevent a crash in Elisa.

lueck updated this revision to Diff 21260.Oct 24 2017, 8:13 PM

update <date> as requested by Luigi

ltoscano accepted this revision.Oct 24 2017, 9:38 PM

Thanks!

This revision is now accepted and ready to land.Oct 24 2017, 9:38 PM
This revision was automatically updated to reflect the committed changes.