Fix wrong LoD plane being used in hidpi mode
AbandonedPublic

Authored by alvinhochun on Sep 25 2017, 5:50 PM.

Details

Summary

When setting the desired LoD plane, take the devicePixelRatio into account. The KisCoordinatesConverter zoom level is calculated in the logical pixel space but the canvas render is performed in device pixel space.

Please test with D7982 applied.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
rempt accepted this revision.Oct 2 2017, 8:26 AM

Just a note: There is a small bug that if the Krita window is moved across two screens with different DPI scale factors, the LoD plane value isn't updated unless the zoom level is changed by the user... but it's not a regression, I can try fixing it later.

(Also happens if the monitor DPI scaling is changed on the fly, but I don't think Qt has an event for detecting it...)

dkazakov requested changes to this revision.Oct 4 2017, 10:09 AM

The problem should be fixed in a different place. Please see this comment for details: https://phabricator.kde.org/D7982#152193

This revision now requires changes to proceed.Oct 4 2017, 10:09 AM
alvinhochun abandoned this revision.Oct 4 2017, 3:17 PM