Differential D7963

share plugin: path display
ClosedPublic
Actions

Authored by thomasp on Sep 24 2017, 8:02 AM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:7d6e48952084: share plugin: path display
Summary

The path displayed in the configuration of the share plugin is wrongly url-encoded on load (and default). This leads to %1 being displayed as %251. Consistently using the text property of kurlrequester fixes this issue.

Test Plan

manual inspection

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thomasp created this revision.Sep 24 2017, 8:02 AM
albertvaka accepted this revision.Sep 24 2017, 6:21 PM
albertvaka added a subscriber: albertvaka.

Thanks for the patch (and for noticing :)!

This revision is now accepted and ready to land.Sep 24 2017, 6:21 PM
Closed by commit R224:7d6e48952084: share plugin: path display (authored by thomasp, committed by albertvaka). · Explain WhyOct 3 2017, 7:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mplugins/share/share_config.cpp (5 lines)

Diff 20317

View Options

plugins/share/share_config.cpp

Loading...