Differential D7946

CSV characters should not be translated
ClosedPublic
Actions

Authored by guoyunhe on Sep 22 2017, 11:02 PM.

Details

Reviewers
danders
mecir
boemann
Group Reviewers
Calligra: 3.0
Commits
R8:5e30a672c634: CSV characters should not be translated
Summary

These characters are used in CSV format and should not change. So they should not be translated. What's more, \r will cause warning in GNU Gettext.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guoyunhe created this revision.Sep 22 2017, 11:02 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptSep 22 2017, 11:02 PM
guoyunhe edited the summary of this revision. (Show Details)Sep 22 2017, 11:05 PM
guoyunhe added a reviewer: Calligra: 3.0.
danders accepted this revision.Dec 8 2017, 6:11 PM
anthonyfieroni added a comment.Mar 22 2018, 8:30 AM

What is state of this review @mecir ?

guoyunhe added a comment.Sep 14 2019, 5:30 PM

How can we push this forward?

Restricted Application added a subscriber: Calligra-Devel-list. · View Herald TranscriptSep 14 2019, 5:30 PM
boemann accepted this revision.Sep 14 2019, 7:02 PM
boemann added a subscriber: boemann.

Looks simple enough to me too - someone please push

This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2019, 8:28 AM
Closed by commit R8:5e30a672c634: CSV characters should not be translated (authored by guoyunhe, committed by Guo Yunhe <i@guoyunhe.me>). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71651

View Options

sheets/plugins/scripting/scripts/csvoptions.ui

Loading...