Add KCM for adjusting QtQuick Rendering in Plasma
ClosedPublic

Authored by davidedmundson on Sep 22 2017, 9:49 AM.

Details

Summary

Does what you imagine it would.
It's akin to KWin's compositor settings, designed to be hidden away and
not used by 99%.

Test Plan

Set some values
Looked at config.
Unset set values

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.Sep 22 2017, 9:49 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 22 2017, 9:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added inline comments.
kcms/qtquicksettings/kcmqtquicksettings.cpp
53

use activated

kcms/qtquicksettings/kcmqtquicksettingswidget.ui
63

Typo

sebas added a subscriber: sebas.Sep 22 2017, 9:58 AM

Can we hide this even more, given that it's an utter expert setting?

kcms/qtquicksettings/qtquicksettings.desktop
14

I think you forgot a few "er", it should be Plasma Renderererererererer, no? ;-)

In D7934#147847, @sebas wrote:

Can we hide this even more, given that it's an utter expert setting?

Any idea where though?

One of my next goals was to make Plasmashell set to use the software renderering if it detects that the context failed to create,
so I do need a somewhat user-visible way for people to reset things once they have things sorted.

Apparently I'm not good at spelliing

Maybe not put it in systemsettings, but tell users to run kcmshell to open it? That really hides it well though, also defeating the purpose...

Thinking of it, wouldn't it make total sense to have this as a QtQuick-only KCM, i.e. using KQuickAddons::ConfigModule?

kcms/qtquicksettings/qtquicksettings.desktop
14

License key would be nice.

Out from experience with the KWin Compositing kcm: hide it well, add more warnings and hide it even more. No matter how much you warn against the settings users will change them. Even if it tells them it's the wrong setting for their system and it's going to break there system: we got bug reports for that.

Given that I'd suggest to not include it in systemsettings and just make it a KCM you can launch from KRunner.

Unrelated: I will piggyback on that for KWin ;-)

mart added a subscriber: mart.Sep 22 2017, 1:32 PM

could them even be merged in the same hidden kcm called "expert settings that you shouldn't use like, ever"? and maybe giving a nice colr palette of red on red :p

davidedmundson marked an inline comment as done.Nov 28 2017, 4:41 PM

expert settings that you shouldn't use like, ever

I do want some people to use them, if I didn't, I wouldn't have written a KCM in the first place.

and just make it a KCM you can launch from KRunner.

@mart any idea how I can do that?

Ping

kcms/qtquicksettings/kcmqtquicksettingswidget.ui
22

Not fond of abusing KMessageWidget for something that isn't action-feedback but this KCM doesn't need to be pretty anyway.

Hide in systemsettings whilst keeping in krunner

abetts added a subscriber: abetts.Apr 22 2018, 2:55 PM

Maybe I can help with this? Also, following the idea of simple, can we add explanatory text to these settings?

You can, but given it's intended audience and how hidden it now is, it really isn't worth putting a lot of time into.

If you don't know what a render loop is, you most definitely don't want to change it

You can, but given it's intended audience and how hidden it now is, it really isn't worth putting a lot of time into.

If you don't know what a render loop is, you most definitely don't want to change it

Love your logic! :D Will do!

mart accepted this revision.Apr 23 2018, 12:35 PM
This revision is now accepted and ready to land.Apr 23 2018, 12:35 PM
This revision was automatically updated to reflect the committed changes.