Reuse the same data when inReplyTo and References are equal
ClosedPublic

Authored by mwolff on Sep 21 2017, 3:28 PM.

Details

Summary

This is only sharing the data within a single mail. It could
be optimized even further by reusing the same instance for every
thread. But I think that's not easy without implementing threading
on the server side.

This decreases peak memory consumption by ~100MB on my mails, when
opening the LKML folder.

Depends on new KMime API (cf. https://phabricator.kde.org/D7920).

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Sep 21 2017, 3:28 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 21 2017, 3:28 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
vkrause accepted this revision.Sep 21 2017, 5:04 PM
This revision is now accepted and ready to land.Sep 21 2017, 5:04 PM

do I need to change anything in the CMakeLists.txt to ensure the up2date kmime is found? or are these repos all implicitly depending on each other anyways?

do I need to change anything in the CMakeLists.txt to ensure the up2date kmime is found? or are these repos all implicitly depending on each other anyways?

You should bump PIM_VERSION in KMime's CMakeLists.txt and adjust KMIME_LIB_VERSION in kdepim-runtime's CMakeLists.txt accordingly.

mwolff updated this revision to Diff 19806.Sep 22 2017, 7:16 PM

depend on new KMime

dvratil accepted this revision.Sep 25 2017, 8:36 AM
This revision was automatically updated to reflect the committed changes.