Differential D7907

old-style-connect: Fix fixit when connecting when the argument type have different const reference
ClosedPublic
Actions

Authored by ogoffart on Sep 21 2017, 10:03 AM.

Details

Reviewers

smartins

Summary

old-style-connect: Fix fixit when connecting when the argument type have different const reference

For example a signal with "const QString&" connected to a slot that have a "QString" parameter

Diff Detail

Repository

R74 Clazy

Lint

Lint Skipped

Unit

Unit Tests Skipped

ogoffart created this revision.Sep 21 2017, 10:04 AM

ogoffart added a reviewer: smartins.Oct 10 2017, 1:44 PM

Looks good, please push to 1.2 branch

This revision is now accepted and ready to land.Oct 10 2017, 2:33 PM

commit 175b6d12c9fe22de1ee854a1c8113ee03954a320 (HEAD -> 1.2, origin/1.2)
Author: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
Date: Wed Oct 11 11:41:41 2017 +0100

old-style-connect: Add a fixit for one more case

Fixes fixit when the argument types have different const reference,
for example "const QString &" vs "QString", which are compatible.

Revision Contents
Changeset List

			Path	Packages
M			src/QtUtils.cpp (6 lines)
M			tests/old-style-connect/main.cpp (4 lines)
M			tests/old-style-connect/main.cpp.expected (15 lines)
M			tests/old-style-connect/main.cpp_fixed.cpp.expected (4 lines)