Unhide autohidden panel when using global menu
ClosedPublic
Actions

Authored by davidedmundson on Sep 20 2017, 9:22 AM.

Details

Reviewers

broulik

Group Reviewers

Plasma

Commits

Summary

This sets a transient parent on the shown menus, meaning a panel knows
to stay open whilst it has any menu showing.

We also pulse setStatus() to trigger activating an autohidden panel if
activated via a shortcut.

BUG: 384861

Test Plan

Ran menu
Using both mouse and keyboard shortcuts navigated a menu
and submenus

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Thanks for looking into this. Plasma/5.11 branch pls

applets/appmenu/lib/appmenuapplet.cpp
216	Hmm, should we perhaps have the applet be Active if a menu is available and Passive if there is none?

This revision is now accepted and ready to land.Sep 20 2017, 6:10 PM

Hmm, should we perhaps have the applet be Active if a menu is available and Passive if there is none?

We could. Not sure it acheives much.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/appmenu/lib/appmenuapplet.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19684	8ca526d		Sep 20 2017, 9:22 AM	★	★
Diff 2	19718	c6cf293	R120:76b276056e0cb39423cccfd2e429a2d65dea3c06	Sep 20 2017, 11:04 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c7da747b10c8	059b4904fd54	8ca526d249b5	David Edmundson	Unhide autohidden panel when using global menu (Show More…)	Sep 20 2017, 9:22 AM