on wayland startup create XDG_RUNTIME_DIR
AbandonedPublic

Authored by sebas on Sep 20 2017, 8:57 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

kwin_wayland wants to put the wayland socket file into XDG_RUNTIME_DIR,
but it doesn't make sure this directory exists. It expects the login
procedure to create it, so let's actually do this.

Test Plan

started plasma/wayland from a console, with this patch, it works

Diff Detail

Repository
R120 Plasma Workspace
Branch
xdgruntimedir
Lint
No Linters Available
Unit
No Unit Test Coverage
sebas created this revision.Sep 20 2017, 8:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 20 2017, 8:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

-1 from my side. This is a clear bug in whatever is used in the login process. If XDG_RUNTIME_DIR is not created we might have a thousand more things which don't work as expected. I rather have KWin bail out early on that one than have to hunt down all the things which might not work because the system is weird.

sebas added a comment.Sep 20 2017, 3:21 PM

That's happening when I start startplasmacompositor by hand, and it's annoying as fuck. Sure, I can add that to my login script, but it's literally the only thing that I have to do to make plasma/wayland come up. Everything else works. (Also, we do create XDG_CONFIG_HOME in the same script, so to me it makes sense to create XDG_RUNTIME_DIR as well (both are user-specific).

In D7882#147153, @sebas wrote:

That's happening when I start startplasmacompositor by hand, and it's annoying as fuck.

AFAIR you are a Debian user, so am I and I don't need to do that. I also start it from console. Seriously this is a problem with your install, pam_systemd should create it on login, see: https://www.freedesktop.org/software/systemd/man/pam_systemd.html

sebas abandoned this revision.Sep 20 2017, 3:28 PM

Ow, see, I was exporting a different XDG_RUNTIME_DIR in my login procedure. I guess removing that fixes the problem as well. :)