Don't recreate kwayland blurmanager on screen size changes

Authored by davidedmundson on Sep 19 2017, 1:44 PM.



Instead of calling reconfigure() on screen size changes, which deletes
and recreates the effect, we can just update the one texture that's mapped to
the screen size.

From the wayland commit.

What surprises me is that BlurManager recreates for Output changes.
That sounds like a bug in KWin (or an area which could be improved).

I had thought the same and wrote this (though wanted to have kwayland fixed first)

Test Plan

Logged in and out (my screen resizes on startup due to scaling)
Tested on my X machine by turning a screen off. Nothing broke, plasma
panels looked the same.

Note: Eike tried this patch last week and claimed kwin still crashed.
We don't have a backtrace so it could have been something unrelated,
applied wrong or that he was deliberately lying to wind me up.

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 19 2017, 1:44 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 19 2017, 1:44 PM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript
davidedmundson edited the summary of this revision. (Show Details)Sep 19 2017, 1:48 PM
graesslin accepted this revision.Sep 19 2017, 3:03 PM
graesslin added a subscriber: graesslin.
graesslin added inline comments.

nitpick: position of {

This revision is now accepted and ready to land.Sep 19 2017, 3:03 PM
This revision was automatically updated to reflect the committed changes.