Differential D7868

Don't scale cursor hotspot differently to cursor
ClosedPublic
Actions

Authored by davidedmundson on Sep 18 2017, 10:53 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R108:4238218b7629: Don't scale cursor hotspot differently to cursor
Summary

In the DRM plugin the cursor is currently is drawn at the native size
given.
Therefore we don't want to scale the icon offset as that leads to it
being drawn every so slightly off-sync.

BUG: 384769
Fixed-in: 5.11.0

Test Plan

Kate now selects lines based on the middle of the cursor, not the top left.
I'd previously gotten so used to it, I hadn't realised it was actually a bug :/

Diff Detail

Repository
R108 KWin
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: KWin. · View Herald TranscriptSep 18 2017, 10:53 AM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript
graesslin accepted this revision.Sep 18 2017, 3:04 PM
This revision is now accepted and ready to land.Sep 18 2017, 3:04 PM
Closed by commit R108:4238218b7629: Don't scale cursor hotspot differently to cursor (authored by davidedmundson). · Explain WhySep 18 2017, 3:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19635

View Options

plugins/platforms/drm/drm_backend.cpp

Loading...
View Options

plugins/platforms/drm/drm_output.cpp

Loading...