Move XFixes cursor change tracking into the x11 standalone platform
ClosedPublic
Actions

Authored by graesslin on Sep 15 2017, 6:01 PM.

Details

Reviewers

None

Group Reviewers

KWin
Plasma

Commits

Summary

A dedicated X11EventFilter is added and created from the X11Cursor in
case we have XFixes. This means some more X11 specific code is now only
on X11.

Test Plan

Run in Xephyr, but no real testing for functionality.

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptSep 15 2017, 6:01 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

Fix crash on startup - cursor is created before Workspace, so the filter creation needs to be delayed

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptSep 22 2017, 6:35 PM

graesslin edited the test plan for this revision. (Show Details)

This revision was automatically updated to reflect the committed changes.

		Path
M		cursor.h (6 lines)
M		cursor.cpp (10 lines)
M		events.cpp (2 lines)
M		plugins/platforms/x11/standalone/CMakeLists.txt (1 line)
M		plugins/platforms/x11/standalone/x11cursor.h (13 lines)
M		plugins/platforms/x11/standalone/x11cursor.cpp (20 lines)
A	M	plugins/platforms/x11/standalone/xfixes_cursor_event_filter.h (41 lines)
A	M	plugins/platforms/x11/standalone/xfixes_cursor_event_filter.cpp (40 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19573	c623db0		Sep 15 2017, 6:01 PM	★	★
Diff 2	19802	8aa7bb2	Fix crash on startup - cursor is created before Workspace, so the filter…	Sep 22 2017, 6:34 PM	★	★
Diff 3	20137	cea7a18	R108:6f99b577360d772c6c2569caf986fa0123486b17	Sep 30 2017, 10:58 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
98aab6a11a49	05d2a34fe19d	8aa7bb28c876	Martin Flöser	Move XFixes cursor change tracking into the x11 standalone platform (Show More…)	Sep 15 2017, 5:59 PM

	Status	Author	Revision
	Closed	graesslin	D7942 Create a dedicated X11Filter for Client sync events and move it to X11 platform
	Closed	graesslin	D7843 Move XFixes cursor change tracking into the x11 standalone platform