Fix trailing space visualization for RTL lines.
It was getting paint on top of the character (to the right of the cursor).
Details
Details
- Reviewers
cullmann - Group Reviewers
KTextEditor - Commits
- R39:bb328146ecd6: Fix trailing space visualization for RTL lines.
Tested and worked for both lines
Diff Detail
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Could you add before/after screenshots for this?
I think this could also help non-RTL users understand what you're fixing. Would be super helpful for me at least :)
Comment Actions
In deed, looks correct now and bogus before.
Please commit.
Could you perhaps add the link to this https://phabricator.kde.org/D7840 to the comment in the code? then we can easy find that again without git blame/...
Comment Actions
Not yet maybe
There are other visualizations that are not working for RTL lines, like non-printable spaces, non-breakable space and tabs. (Indent markers are not needed for RTL lines)
They don't appear at all. I tried fixing them but didn't succeed :p
Comment Actions
Sorry, my mistake. The post-commit trigger thing didn't close this, maybe because the #post part is there /me how come I didn't notice! :|
Update: it worked after a while, hmm.
https://cgit.kde.org/ktexteditor.git/commit/?id=bb328146ecd64f97710eb09f568001cd4d40f622
Comment Actions
The hook doesn't cause the immediate closure of a diff. The hook asks Phabricator's background processes to initiate an update of the repository.
When those commits are processed, the review gets closed.
Depending on how busy Phabricator is processing other commits this can take a few minutes to take place.