Use a different key for font DPI on X and Wayland
ClosedPublic

Authored by davidedmundson on Sep 14 2017, 9:45 PM.

Details

Test Plan

Saved config under X
opened file
Saved config under wayland

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 14 2017, 9:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 14 2017, 9:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson retitled this revision from Use a different vallue for font DPI on X and Wayland to Use a different key for font DPI on X and Wayland.Sep 14 2017, 9:47 PM
hein added a subscriber: hein.Sep 15 2017, 6:32 AM

The patch makes sense, but doesn't this indicate we screwed up something conceptually because the user now needs to set font dpi in awareness they'll be scaled after instead of set directly?

In D7831#145979, @hein wrote:

The patch makes sense, but doesn't this indicate we screwed up something conceptually because the user now needs to set font dpi in awareness they'll be scaled after instead of set directly?

Kinda, I want users who have scaling to not touch this setting.
It's at the wrong level, it's static and global and overall rubbish.

hein accepted this revision.Sep 15 2017, 7:03 AM
This revision is now accepted and ready to land.Sep 15 2017, 7:03 AM
This revision was automatically updated to reflect the committed changes.