Differential D7804

Update CMakeLists
ClosedPublic
Actions

Authored by laysrodrigues on Sep 13 2017, 4:12 PM.

Details

Reviewers
rizzitello
tcanabrava
patrickelectric
Maniphest Tasks
T6953: Add KDE Frameworks flag on Cmakelists
Commits
R231:f23f82f22334: Update gitignore
R231:b77dfd3dc9c9: Update CMakeLists
R231:524ae6b14c70: Update main to use the config.h
Summary

Updates necessary to set Qt and KDE Frameworks base
version to be used on this project.

Add a config.h.cmake file to make the version be
set automatically based on this file. This
file gets the version from the CMakeLists
version. And I think that those variables can be
manage by scripts, based on Kate setup.

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Update main to use the config.h

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Update gitignore

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Repository
R231 Atelier
Branch
work
Lint
No Linters Available
Unit
No Unit Test Coverage
laysrodrigues created this revision.Sep 13 2017, 4:12 PM
tcanabrava edited edge metadata.Sep 14 2017, 1:41 PM

looks good. You told me that you don't know what one line does, can you comment on that?

tcanabrava accepted this revision.Sep 14 2017, 1:41 PM
This revision is now accepted and ready to land.Sep 14 2017, 1:41 PM
laysrodrigues added a comment.Sep 14 2017, 1:49 PM
In D7804#145726, @tcanabrava wrote:

looks good. You told me that you don't know what one line does, can you comment on that?

The line 50. I'm doing this setup based on Kate CMakeLists, and that is the line is in the group related to config.h.cmake stuff... But I can't find any relationship on it. I will remove it and update this diff to merge.

laysrodrigues updated this revision to Diff 19528.Sep 14 2017, 2:53 PM
  • Update main to use the config.h
  • Update gitignore
laysrodrigues closed this revision.Sep 14 2017, 3:10 PM

Was merged and not closed by arc...

Revision Contents
Changeset List

PathPackages
M.gitignore (2 lines)
MCMakeLists.txt (22 lines)
AMconfig.h.cmake (5 lines)
Msrc/main.cpp (3 lines)

Diff 19528

View Options

.gitignore

Loading...
View Options

CMakeLists.txt

Loading...
View Options

config.h.cmake

Loading...
View Options

src/main.cpp

Loading...