Differential D7798

[Folder View] Fix supported drag actions
ClosedPublic
Actions

Authored by broulik on Sep 13 2017, 12:07 PM.

Details

Reviewers
hein
davidedmundson
Group Reviewers
Plasma
Commits
R119:6b8fa112f47d: [Folder View] Fix supported drag actions
Summary

SetSupportedDragActions is deprecated and doesn't seem to work.
This fixes modifier shortcuts for dragging, e.g. dragging with Ctrl+Shift to create a link.

BUG: 382797

Test Plan

I can now Ctrl+Shift and drag to create a link as well as Shift and drag to move.
The cursor also changes to the appropriate "will create a link" cursor when doing the former.

Selection when starting another drag after having used modifiers is erratic but that's a different issue.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 13 2017, 12:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 13 2017, 12:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Sep 13 2017, 2:27 PM
This revision is now accepted and ready to land.Sep 13 2017, 2:27 PM
hein accepted this revision.Sep 13 2017, 7:37 PM
Closed by commit R119:6b8fa112f47d: [Folder View] Fix supported drag actions (authored by broulik). · Explain WhySep 14 2017, 8:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19479

View Options

containments/desktop/plugins/folder/foldermodel.h

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...