could you rename all Q_DECL_OVERRIDE to override please ?

could you add EWSRES_LOG to kdepim-runtime.categories please ? so we can load this info in kdebugsettings thanks

i18n ? setErrorText is displaying in a messagebox no ?

could you replace Q_NULLPTR by nullptr thanks :)

coding style EwsClient &client

i18n ?

debug file is not autogenerated ? see ecm_qt_declare_logging_category(kolabresource_SRCS HEADER kolabresource_debug.h IDENTIFIER KOLABRESOURCE_LOG CATEGORY_NAME org.kde.pim.kolabresource)

const here ?

const QXmlStreamReader

replace = 0 to nullptr ?

const QString &

const/ref

i18n ?

const QXmk... &

why not using evName for each if(...) ?

cache reader.name() value

const QString &

const ... &

Remove debug here no ?

qCDebug

nullptr + explicit

nullptr

nullptr

The implementation calls QXmlStreamReader::readNextStartElement(), which is a non-const member.

The implementation calls QXmlStreamReader::readNextStartElement(), which is a non-const member.

The implementation calls QXmlStreamReader::readNextStartElement(), which is a non-const member.

ok

This looks unused now?

Does the EWSItem contain actual information regarding the timezone, except for its name, like UTC offset and DST transitions?

I know realize KCalCore may not have the API you might need to get this working properly, but I don't know how much information you actually have available for EWS events

If the errorText of the job is passed to Akonadi::ResourceBase::cancelTask() at some point, it should be localized (and probably less technical, that's what debug output is for)

You're right - I missed that when converting to QDateTime.

In the current form the data downloaded from Exchange contains full vCalendar payload including the timezone specification. This I believe is handled by the updated KCalCore code, that I asked about in one of the previous comments.

This implementation is however temporary as it doesn't provide room to implement calendar modifications. To do that I'll need to download the events piece by piece including the timezone. The Exchange server provides the timezone name as well as offset information, so it will be enough to do proper conversion. This is the moment I'll need to hook up to KCalCore's timezone processing code, but I'm not too worried about it ATM.

This used to be like that in the beginning, but after addressing Laurent's comments I have changed this behaviour - the exact message is only printed to the log and the user is presented with a more generic message that item retrieval has failed (see ewsresource.cpp:608)

could you rename it as config-ews.h.cmake ... config-ews.h ?
It avoid to have a lot file with same name.
Thanks

not necessary

remove virtual keyword

Remove all virtual keyword when you have override thanks

Add parent to QDialogButtonBox it can create a bug where default button is not correct (for example it can select cancel and not ok in some case)
thanks

pedantic no .? we don't need ";"
Same for all other methods

pedantic

const QString &msg

cache reader.name() seems better

const QSharedPointer &upd

I think that you remove check