make krunner accessible
ClosedPublic

Authored by mart on Sep 11 2017, 10:55 AM.

Details

Summary

enable actual keyboard navigation, as the previous
completely manual keyboard navigation in krunner completely broke
the screen reader support, rendering it inaccessible (while
potentially krunner is one of the most useful apps for blind
users)

Test Plan

tested to navigate with keyboard (still similar behavior as before)
while having orca running, which correctly read the result entries

Diff Detail

Repository
R120 Plasma Workspace
Branch
accessiblekrunner
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Sep 11 2017, 10:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 11 2017, 10:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart updated this revision to Diff 19403.Sep 11 2017, 12:40 PM
  • better navigation
mart updated this revision to Diff 19424.Sep 11 2017, 8:47 PM
  • run current result on enter

Lovely! Just a bit of nit-picking.

krunner/view.cpp
65

I'd remove the "on" :)

lookandfeel/contents/runcommand/RunCommand.qml
118

Left over comment?

mart updated this revision to Diff 19427.Sep 11 2017, 9:07 PM
  • remove dead code
davidedmundson accepted this revision.Sep 12 2017, 10:06 AM
This revision is now accepted and ready to land.Sep 12 2017, 10:06 AM
This revision was automatically updated to reflect the committed changes.
abetts added a subscriber: abetts.Sep 12 2017, 3:14 PM
In D7765#144777, @mart wrote:
  • better navigation

Can I help in this area? Does it mean visual design?