BUG: 354149
Always show the Rotate Left and Rotate Right operations in the Image Operations sidebar when other edit operations are visible.
Details
Details
- Reviewers
aacid broulik cfeck jensreuterberg - Group Reviewers
KDE Applications VDG - Commits
- R260:144f440cb76c: Always show image rotation buttons in Image Operations sidebar when other…
Tested in KDE Neon (dev unstable). Works as expected:
Diff Detail
Diff Detail
- Repository
- R260 Gwenview
- Branch
- arcpatch-D7743
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
I have a feeling that the reason why these were hidden from the Image Operations panel is because by default there are toolbar items for rotation, but various people complained anyway:
https://bugs.kde.org/show_bug.cgi?id=354149
https://bugs.kde.org/show_bug.cgi?id=357771
Also, it seems a little odd that they'd just be *gone*. And if you customize the toolbar to remove them, they'd still be gone from the Image Operations panel. Seems like it makes sense to add them back.
Comment Actions
Hmm, I can see why both solutions would be valid, though I would tend to having the options in the sidebar only if the toolbar does not have them. Perhaps ask VDG/Usability for input.
Comment Actions
ADDING VDG. I think it still makes sense to keep them in the toolbar as well, since there are many times when you might not have the Operations panel open but still want to rotate an image (it's one of the most basic operations).
Comment Actions
Let's go for it.
Just remove the lines instead of leaving commented code, we can still retrieve it from git history should the need arise.