Differential D7735

[KateFileTreeModel] Don't iterate over keys()
ClosedPublic
Actions

Authored by broulik on Sep 8 2017, 2:06 PM.

Details

Reviewers
brauch
Group Reviewers
Kate
Commits
R40:2ce3374f08f5: [KateFileTreeModel] Don't iterate over keys()
Summary

Creates a temporary list just to iterate it. Use iterators instead.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 8 2017, 2:06 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptSep 8 2017, 2:06 PM
brauch accepted this revision as: brauch.Sep 8 2017, 2:09 PM
brauch added a subscriber: brauch.

range-based for would detach ...?
If you had a reason not to use that, LGTM, thanks!

This revision is now accepted and ready to land.Sep 8 2017, 2:09 PM
broulik added a comment.Sep 8 2017, 2:21 PM

Range for also iterates only values

Closed by commit R40:2ce3374f08f5: [KateFileTreeModel] Don't iterate over keys() (authored by broulik). · Explain WhySep 14 2017, 10:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19515

View Options

addons/filetree/katefiletreemodel.cpp

Loading...