Update configuring.docbook to ktexteditor 5.38
ClosedPublic

Authored by lueck on Sep 7 2017, 5:42 AM.

Details

Summary

add missing options in confix dialog
update + cleanup document variables section

Test Plan

checkXML5 index.docbook

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
lueck created this revision.Sep 7 2017, 5:42 AM
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptSep 7 2017, 5:42 AM
dhaumann requested changes to this revision.Sep 7 2017, 7:17 AM
dhaumann added a subscriber: dhaumann.

Thanks for working on this. The patch looks pretty good, and after another iteration I'm confident we can merge this.

doc/katepart/configuring.docbook
168 ↗(On Diff #19260)

Typo: hoover -> hover

1295 ↗(On Diff #19260)

This will get outdated again and again. Maybe just say: The variables listed here documents the current state. More ...

Or similar?

1313 ↗(On Diff #19260)

spell-checking in the auto-brackets section looks wrong. Could you have a second look?

1389 ↗(On Diff #19260)

remove "on"

1474 ↗(On Diff #19260)

Instead of the term 'conversion' we may want to use "expansion". But I may be wrong, since I am not a native English speaker.

doc/katepart/development.docbook
276 ↗(On Diff #19260)

Good catch! :-)

This revision now requires changes to proceed.Sep 7 2017, 7:17 AM
lueck updated this revision to Diff 19265.Sep 7 2017, 1:03 PM
lueck edited edge metadata.

fix some issues spotted by Dominik

lueck marked 4 inline comments as done.Sep 7 2017, 1:08 PM
lueck added inline comments.
doc/katepart/configuring.docbook
1295 ↗(On Diff #19260)

I'd prefer to have a date/version similar to date/releaseinfo in the docbook header.
This helps to see if the info could be obsolete as before this patch with "version 3.7"

1389 ↗(On Diff #19260)

frameworks/ktexteditor/src/variableeditor/variablelineedit.cpp:200 has this typo as well:
item->setHelpText(i18nc("short translation please", "Enable folding preview on in the editor border."));

dhaumann accepted this revision.Sep 7 2017, 2:33 PM

Looks good, if you want, you can fix the typo in variablelineedit.cpp as well.

This revision is now accepted and ready to land.Sep 7 2017, 2:33 PM
lueck marked 2 inline comments as done.Sep 7 2017, 2:53 PM
lueck added inline comments.
doc/katepart/configuring.docbook
1389 ↗(On Diff #19260)
This revision was automatically updated to reflect the committed changes.
lueck marked an inline comment as done.