[WIP] Minimze the use of bidi markers in IRCView.
ClosedPublic

Authored by safaalfulaij on Sep 5 2017, 8:45 PM.

Details

Summary

Some apps can't handle the RLM/LRM characters used in the textview when copied.
This shall decrease the use to it's minimum.

Test Plan

Needs more testing.

Diff Detail

Repository
R7 Konversation
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
safaalfulaij created this revision.Sep 5 2017, 8:45 PM
safaalfulaij retitled this revision from Minimze number of bidi markers used in IRC::View. to [WIP] Minimze the use of bidi markers in IRCView..Sep 5 2017, 8:52 PM
safaalfulaij edited the summary of this revision. (Show Details)
safaalfulaij edited the test plan for this revision. (Show Details)
argonel requested changes to this revision.Sep 15 2017, 7:32 AM
argonel added a subscriber: argonel.

The blocks starting at 565, 623 and 683 and possibly 801 look like duplicates to me. Perhaps factor these out into a helper method? I didn't actually compare every line, so if they're not strict duplicates ignore me.

src/viewer/ircview.cpp
605

The comments like this probably mean something, please expand into something more like documentation.

This revision now requires changes to proceed.Sep 15 2017, 7:32 AM
safaalfulaij edited edge metadata.
  • Some refactoring and documentation
  • Better direction for log view lines.
  • Fix action's line alignment
argonel requested changes to this revision.Nov 6 2017, 7:32 AM

Once those changes are made, please rebase on 1.7 branch, commit to 1.7 and merge to master.

Thanks!

src/viewer/ircview.cpp
838

Should be two lines, ensure both the conditional and ternary are required.

840

Should be two lines, ensure both the conditional and ternary are required.

This revision now requires changes to proceed.Nov 6 2017, 7:32 AM
  • Fix comment and apply comments
  • Rebase (I think I messed up my git copy as usual)
  • Revert last nonsense commit
  • Fix comment and apply comments

Ok, I applied the comment, but now I have no idea how to merge, rebase and other stuff, sorry! :(
Please do it instead since my knowledge in Git is below zero.

Thanks for the hard work! :-)

This revision was automatically updated to reflect the committed changes.