Differential D7693

Enable reproducible packaging of template archives
ClosedPublic
Actions

Authored by aaronpuchert on Sep 4 2017, 10:18 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:95b60e927cdb: Enable reproducible packaging of template archives
Summary

Builds of KDevelop are not reproducible right now because the archives
containing templates contain metadata related to the build environment,
such as the time of checkout. The order of files in an archive is also
not guaranteed.

The Reproducible Builds project recommends [1] to use (in addition to
what we have) --mtime="@${SOURCE_DATE_EPOCH}" and --sort=name. This will
only be used if the environment variable is set. The latter option is
available only since tar 1.28 (from 2014), but we assume that people
have it if they know about reproducible builds.

[1] https://reproducible-builds.org/docs/archives/

Diff Detail

Repository
R32 KDevelop
Branch
reproducible-build
Lint
No Linters Available
Unit
No Unit Test Coverage
aaronpuchert created this revision.Sep 4 2017, 10:18 PM
kfunk requested changes to this revision.Sep 4 2017, 10:41 PM
kfunk added a subscriber: kfunk.
kfunk added inline comments.
kdevplatform/cmake/modules/KDevPlatformMacros.cmake
65

Can you refactor this so you don't need another add_custom_command call?

i.e. put this in the else() branch:

set(extraArgs "")
if (DEFINED ENV{...})
   set(extraArgs "--mtime=...")
endif()
add_custom_command(...
  ... ${extraArgs} ...

)

This revision now requires changes to proceed.Sep 4 2017, 10:41 PM
Closed by commit R32:95b60e927cdb: Enable reproducible packaging of template archives (authored by aaronpuchert, committed by kfunk). · Explain WhySep 5 2017, 7:46 AM
This revision was automatically updated to reflect the committed changes.
aaronpuchert added a comment.Sep 5 2017, 6:31 PM

I see you already submitted the change, but you omitted --sort=name.

Was that oversight, or is there a reason for that?

kdevplatform/cmake/modules/KDevPlatformMacros.cmake
65

Yes, that's probably a good idea.

kfunk added a comment.Sep 5 2017, 7:27 PM
In D7693#143253, @aaronpuchert wrote:

I see you already submitted the change, but you omitted --sort=name.

Was that oversight, or is there a reason for that?

Sorry, oversight. Fixed now with https://commits.kde.org/kdevelop/75e9fe4bbd9696350be970bba189b2acba51518f

Revision Contents
Changeset List

Diff 19192

View Options

kdevplatform/cmake/modules/KDevPlatformMacros.cmake

Loading...