Don't show a region selector when selecting avatars from a gallery
ClosedPublic

Authored by davidedmundson on Sep 4 2017, 11:36 AM.

Details

Summary

Prompting the user for a region makes sense when loading from a file,
but not from the gallery.

CreateAvatarJob does two things:

  • copies from KIO
  • goes via a KPixmapRegionSelector and saves to a local file

We know the gallery files are locally mounted, and we don't want the
region selector so we can just skip the job completely.

Test Plan

Set avatar from file. Got prompt, saved properly
Set avatar from gallery. Skipped prompt, saved properly

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 4 2017, 11:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 4 2017, 11:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Sep 6 2017, 8:50 AM
This revision is now accepted and ready to land.Sep 6 2017, 8:50 AM
This revision was automatically updated to reflect the committed changes.