Removed dependency of ball direction on mouse buttons
ClosedPublic
Actions

Authored by rohitdas on Sep 4 2017, 9:12 AM.

Details

Reviewers

Group Reviewers

GCompris
GCompris: Improvements

Summary

Ref: D7231. Created new revision. Please review.

Diff Detail

Repository

R2 GCompris

Lint

Lint Skipped

Unit

Unit Tests Skipped

rohitdas created this revision.Sep 4 2017, 9:12 AM

rohitdas added a subscriber: jjazeix.Sep 5 2017, 4:22 PM

jjazeix added inline comments.Sep 5 2017, 6:53 PM

src/activities/penalty/Penalty.qml
61	missing space
107	duplicate with previous line
122	harcoded values, if you resize the screen (reduce the width at minimum), it does not work as expected (if you click on top, it would go on left or right). To debug, you can temporary put colors to the zones and be sure they cover what they should.

Removed hard-coded values, and committed other changes as requested. Please review.

Hi, globally, it's good, just one last change for this patch.
Another improvement (can be another patch) is to better handle the mouse clicks.
For now, if you click on left side and then on right side, both progress bar will be activated. We don't want this, we should not activate the second progress bar on this case.
Also, mutliple clicks on one zone make the game win multiple times, we also don't want this.

src/activities/penalty/Penalty.qml
93	I would use anchors where possible instead of fixing width/height (basically, on this case, the width does not need to be set as we can anchor to the player image, the middle rectangle can be anchors to the other two)

jjazeix requested changes to this revision.Sep 10 2017, 1:03 PM

This revision now requires changes to proceed.Sep 10 2017, 1:03 PM