Don't leak the Akonadi::Monitor
ClosedPublic

Authored by dvratil on Sep 4 2017, 12:35 AM.

Details

Summary

The Akonadi::MonitorImpl leaks the internal instance of Akonadi::Monitor. Probably not really a problem during regular Zanshin use, but creates a mess during unit-tests.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Sep 4 2017, 12:35 AM
ervin requested changes to this revision.Sep 4 2017, 5:52 AM

I think the mistake was not passing the MonitorImpl to the Monitor at construction time. Could you please do that instead?

This revision now requires changes to proceed.Sep 4 2017, 5:52 AM
dvratil updated this revision to Diff 19158.Sep 4 2017, 10:43 AM
dvratil edited edge metadata.
ervin accepted this revision.Sep 4 2017, 11:16 AM
This revision is now accepted and ready to land.Sep 4 2017, 11:16 AM
This revision was automatically updated to reflect the committed changes.