Change version to match KDE Applications (17.11.70)
ClosedPublic

Authored by alexeymin on Sep 2 2017, 4:46 PM.

Details

Summary

Previously krfb had version set to 5.0. This is misleading.
Now, do the same as other standard KDE apps, like ark or dolphin: use
KDE_APPLICATIONS_VERSION_MAJOR, KDE_APPLICATIONS_VERSION_MINOR, etc.
This page: https://www.kde.org/applications/system/krfb has a link to report a bug: https://bugs.kde.org/enter_bug.cgi?format=guided&product=krfb
Versions in bugzilla have 17.xx.xx, so "About..." window should match.

cmake: Set version in project(); use ecm_setup_version() call

Inspired by commit in Ark: cffecfbfffd22bc0bbe451ed8d74f3b6da113c6f

Test Plan

Compile, run. Make sure that Help -> About Desktop Sharing displays the correct version.

Diff Detail

Repository
R437 Desktop Sharing
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alexeymin created this revision.Sep 2 2017, 4:46 PM
alexeymin edited the summary of this revision. (Show Details)Sep 2 2017, 4:52 PM
alexeymin edited the test plan for this revision. (Show Details)
alexeymin edited the summary of this revision. (Show Details)Sep 2 2017, 5:01 PM
alexeymin added a project: KDE Applications.
alexeymin edited the summary of this revision. (Show Details)

I'm not sure what is KDE policy about versioning. My impression is that 5.x versions are ok for projects that are not released with KDE Applications (like KTorrent?), but krfb is released together with others that have version numbers like 17.04, 17.08, ...
What do you think?

CMakeLists.txt
12

Not sure about what KF5_MIN_VERSION should be. What is recommended acceptable minumum?

aacid edited edge metadata.Sep 2 2017, 5:27 PM

Guideline is at https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning

You can use the full version or also partially "Beside using the full version, you could use only the patch release version ${KDE_APPLICATIONS_VERSION_MICRO} to suffix your own version if you don't want to do that manually for each patch release. " like Okular does

ltoscano edited edge metadata.Sep 2 2017, 5:40 PM

As Albert wrote, you can use whatever version you want: check the version number of the games, or many applications of the edu group.

Some application decided to use to version.of the bundle, but... up to you.

alexeymin updated this revision to Diff 19143.Sep 3 2017, 4:06 PM
alexeymin edited the summary of this revision. (Show Details)
  • Use QStringLiteral around KRFB_VERSION_STRING
In D7658#142399, @aacid wrote:

Thanks for guide! And for Okular example too. So, according to your mail to release_team, CMake project() with VERSION is needed for bugzilla sync anyway; and version 5.0 does not fit to both versionng schemes, so something has to be changed anyway.

... check the version number of the games, or many applications of the edu group.

I don't use games or edu programs, but again, all "standard" kde apps that I see, like: dolphin, kate, kcalc, ark, kolourpaint, spectacle, .. show 17.08 version. And in my package manager (portage!) krfb package is called kde-apps/krfb-17.08.0 (KDE Neon shows krfb/xenial,now 4:17.08.0+p16.04+git20170831.1851-0 too) so as user I would expect to see 17.08 in "About..." window. Okular looks strange in this regard (kde-apps/okular-17.08.0 and 1.2.0 in "About") ;)

If it's up to me I'd prefer automatically updated version mathcing to KDE Applications version.

Bump
Can any of you accept this diff or explicitly say that this is incorrect so I can commit or abandon this and move on?
In order to not have it hanging here forever ...

aacid added a comment.Sep 6 2017, 5:31 PM

It's not right nor wrong, you have to decide if you think it makes sense :)

This revision was automatically updated to reflect the committed changes.