Move XRandR event filter into XRandRScreens
ClosedPublic
Actions

Authored by graesslin on Sep 2 2017, 9:50 AM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:4fa41165d190: Move XRandR event filter into XRandRScreens

Summary

The code in events.cpp was problematic as it was called in a Wayland
session. So KWin changed outputs, this gets mirrored to XWayland and
then KWin reacted on the XRandR event and might have even changed the
refresh rate due to that - bad idea.

This change moves the code into the already existing X11EventFilter for
XRandR events in XRandRScreens.

Test Plan

Run kwin_x11 in gdb on Xephyr, breakpoint in new code and triggered XRandR event

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Sep 2 2017, 9:50 AM

Restricted Application added a project: KWin. · View Herald TranscriptSep 2 2017, 9:50 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

ping

davidedmundson accepted this revision.Sep 10 2017, 3:57 PM

This revision is now accepted and ready to land.Sep 10 2017, 3:57 PM

Closed by commit R108:4fa41165d190: Move XRandR event filter into XRandRScreens (authored by graesslin). · Explain WhySep 12 2017, 4:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/mock_workspace.h (4 lines)
M			events.cpp (26 lines)
M			options.h (2 lines)
M			options.cpp (5 lines)
M			plugins/platforms/x11/standalone/screens_xrandr.cpp (26 lines)