Differential D7633

[Digital Clock] Compact and move to the end font setup
ClosedPublic
Actions

Authored by broulik on Aug 31 2017, 3:16 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
VDG
Commits
R120:a8ae90067183: [Digital Clock] Compact and move to the end font setup
Summary

This makes the font selector more compact and moves it to the end of the dialog.
Settings like show seconds and date are more important than using a custom font for the clock.

Test Plan


Changing font, bold, and italic still work

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Aug 31 2017, 3:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 31 2017, 3:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 1 2017, 9:45 AM
mart added a subscriber: mart.

I like it

This revision is now accepted and ready to land.Sep 1 2017, 9:45 AM
mck182 added a subscriber: mck182.Sep 1 2017, 9:50 AM

The horizontal alignment of the label is off compared to the rest of the labels, I guess it's because it's not in a groupbox.

broulik added a comment.Sep 1 2017, 10:04 AM

I guess it's because it's not in a groupbox.

Yes, it is not, as it's not "Information" and I didn't want to put a new GroupBox around it for that one item.

Closed by commit R120:a8ae90067183: [Digital Clock] Compact and move to the end font setup (authored by broulik). · Explain WhySep 8 2017, 12:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19017

View Options

applets/digital-clock/package/contents/ui/configAppearance.qml

Loading...