EmailAddressSelectionWidget: use ETM signal to expand, rather than 1s timer.
ClosedPublic

Authored by dfaure on Aug 30 2017, 9:40 AM.

Details

Summary

This leads to much better use interface, the signal being emitted much
faster than 1s (it's emitted when the collections have been listed,
before the items themselves are listed), it also works around a crash
in QSFPM that happens sometimes when the listing isn't done after 1s
(sounds like ETM or one of the proxies is in an inconsistent state,
something which I still have to debug)

Test Plan

emailaddressselectionwidgettest no longer crashes for me.

Diff Detail

Repository
R459 Akonadi Contacts
Branch
Applications/17.08
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Aug 30 2017, 9:40 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 30 2017, 9:40 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
dfaure edited the test plan for this revision. (Show Details)Aug 30 2017, 9:42 AM
dfaure added reviewers: mlaurent, dvratil.
mlaurent accepted this revision.Aug 30 2017, 11:45 AM
This revision is now accepted and ready to land.Aug 30 2017, 11:45 AM
dfaure closed this revision.Sep 9 2017, 10:26 AM