Differential D7598

[Folder Model] Introduce status enum
ClosedPublic
Actions

Authored by broulik on Aug 29 2017, 9:05 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:c77e9542005f: [Folder Model] Introduce status enum
Summary

This allows to use bindings for properties like plasmoid.busy

Test Plan

Will update D7586 based on this once it's in.

Verified that on startup it circles while it's reading the dir. It does not do that when changing the config but I think it didn't do that before (if (!grid.model) ...)
Verified that error string is properly shown and doesn't keep spinning in case of error

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 29 2017, 9:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 29 2017, 9:05 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Aug 29 2017, 1:23 PM

Nice!

This revision is now accepted and ready to land.Aug 29 2017, 1:23 PM
Closed by commit R119:c77e9542005f: [Folder Model] Introduce status enum (authored by broulik). · Explain WhyAug 30 2017, 8:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18946

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.h

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...